WIP: Fix incorrect parsing of bfrange (#631) #763
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the regular expression for single-offset bfrange mapping unintentionally matched portions of the bracketed array form. This caused extremely large code range, leading to out of memory. Now, we capture the `<from>` and `<to>` ranges first and then distinguish between single-offset (`<xxxx>`) and array (`[<xxxx> <xxxx> ...]`) forms. This ensures that the single-offset regex won't accidentally match bracketed segments.
You don't need a real PDF file, instead create Here are a few starting points which might help: |
|
Thank you, @k00ni, I'll try it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request
About
fixes #631
Previously, the regular expression for single-offset bfrange mapping unintentionally matched portions of the bracketed array form. This caused extremely large code range, leading to out of memory.
Now, we capture the
<from>and<to>ranges first and then distinguish between single-offset (<xxxx>) and array ([<xxxx> <xxxx> ...]) forms. This ensures that the single-offset regex won't accidentally match bracketed segments.Checklist for code / configuration changes
See CONTRIBUTING.md for all essential information about contributing.
TODO
Question:
In order to write test code, I need to generate a PDF that contains arbitrary
bfrangesections. However, I’m afraid I don’t know how to do that. Do you have any suggestions on how to create such a file?